Delete NCP created resources in cleanup #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuntanghsu
force-pushed
the
topic/hsuy/certificate
branch
from
f75fd5c
to
dd5b667
Compare
yuntanghsu
force-pushed
the
topic/hsuy/certificate
branch
from
dd5b667
to
3779851
Compare
TaoZou1
reviewed
Jul 29, 2024
yuntanghsu
force-pushed
the
topic/hsuy/certificate
branch
from
3779851
to
0a5e09d
Compare
yuntanghsu
changed the title
yuntanghsu
force-pushed
the
topic/hsuy/certificate
branch
3 times, most recently
from
cb9952c
to
63b26ee
Compare
dantingl
previously approved these changes
Aug 21, 2024
yuntanghsu
force-pushed
the
topic/hsuy/certificate
branch
2 times, most recently
from
be1d597
to
d6bbaeb
Compare
yuntanghsu
force-pushed
the
topic/hsuy/certificate
branch
from
d6bbaeb
to
a754dc3
Compare
dantingl
previously approved these changes
Aug 28, 2024
yuntanghsu
force-pushed
the
topic/hsuy/certificate
branch
from
a754dc3
to
7cfb8d3
Compare
In this change, we delete NCP created resource (share/sharedResource/certificate/lbAppProfile/lbPersistenProfile) in the cleanup process. Signed-off-by: Yun-Tang Hsu <hsuy@vmware.com>
yuntanghsu
force-pushed
the
topic/hsuy/certificate
branch
from
7cfb8d3
to
de96548
Compare
salv-orlando
approved these changes
Aug 28, 2024
salv-orlando
approved these changes
Aug 28, 2024
@yuntanghsu you need approval from a maintainer, unfortunately |
dantingl
approved these changes
Sep 2, 2024
TaoZou1
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we delete NCP created resource (share/sharedResource/certificate/lbAppProfile/lbPersistenProfile) in the cleanup process.